Enabled doesn't work if Edit is connected to the DataSource

[asp]

Hi!
If Edit is connected to the datasource, Enabled doesn't work properly. You can't make the control disabled. Even if you set Enabled = false, the component will be active. Datalink.StateChangeOperation is set to scoNone. The same problem seems to affect all the controls with DataLink property. See attached project.

[Alexander Bulei]

Hi asp,

Fixed. It was only appearance issue.
Thanks

Best Regards.

[asp]

Hi, Alexander!

I tried the version 3.0.0.87 and it doesn't repair the bug. Check out the test project I posted before.

I guess the problem with the following code in procedure TIWCGJQCustomEdit.DataLinkActiveChange

Code: Select all

if Assigned(DataLink.DataSource) and Assigned(DataLink.DataSource.DataSet) then
  begin
    if not IsDesignMode then
      Enabled:= DataLink.DataSource.DataSet.Active;

    case DataLink.StateChangeOperation of
      scoEnable: Enabled:= DataLink.DataSource.DataSet.Active and DataLink.Editing;
      scoReadOnly: ReadOnly:= not (DataLink.DataSource.DataSet.Active and DataLink.Editing);
    end;
...
end;


You don't take into account the fact that the control could be disabled 'by design'. So, the code should be something like this

Code: Select all

if Assigned(DataLink.DataSource) and Assigned(DataLink.DataSource.DataSet) then
  begin
    if Enabled then begin
    if not IsDesignMode then
      Enabled:= DataLink.DataSource.DataSet.Active;

    case DataLink.StateChangeOperation of
      scoEnable: Enabled:= DataLink.DataSource.DataSet.Active and DataLink.Editing;
      scoReadOnly: ReadOnly:= not (DataLink.DataSource.DataSet.Active and DataLink.Editing);
    end;
 end;
...
end;


[Alexander Bulei]

Hi asp,

When control is attached to DB (via DataLink), as you can see, begins to be controlled by DataSet.

Best Regards.

[asp]

Hi, Alexander!

Hi asp,

When control is attached to DB (via DataLink), as you can see, begins to be controlled by DataSet.

Best Regards.

Yes, I understand that. And I think it is not correct. For example, I want to have an edit control attached to the dataset, but disabled to show the user that he can not change the value.