Validation still has problems

[asp]

Hello!

I've made a project showing a problem with validation. Once again IsValid property works incorrect. Now, it contains false when actually validation must return true. May be it happens when you create controls dynamically. See attached project.

[Alexander Bulei]

Hi asp,

Can you explain better?

Maybe this topic help you: viewtopic.php?f=3&t=1366

Video attached.

Best Regards.

[asp]

The issue is shown on your video When you press OK button, the dialog should close because the validation succeeds (it can be noticeable by the green frame around the edit).
But when we test IsValid property on the server side, it will contain false, so we don't close the dialog. See the code:

Code: Select all

procedure TfrDia.IWFrameRegionJQDialogOptionsButtons0Click(Sender: TObject;
  AParams: TStringList);
var C: TComponent;
    JQValidateOpt: TIWCGJQValidateOptions;
begin
  for C in IWFrameRegion do begin
    if IsPublishedProp(C, 'JQValidateOptions') then begin
      JQValidateOpt := TIWCGJQValidateOptions(GetObjectProp(C, 'JQValidateOptions'));
      if JQValidateOpt.Enable then begin
        JQValidateOpt.Validate;
        if not JQValidateOpt.IsValid then begin
          Exit;
        end;
      end;
    end;
  end;
  IWFrameRegion.JQDialogOptions.Close();
end;


The dialog will be closed if we press OK button for the second time.

[asp]

Hi!
Was my explanation clear enough? Do you see the problem?

[Jorge Sousa]

Hello

You cannot call JQValidateOpt.Validate that performs the validation in the browser, and immediatelly call JQValidateOpt.IsValid to check, because only the next event will be valid.

ie, JQValidateOpt.Validate doesn't call the browser, waits and backs to server.

[asp]

Hi!

Consider very natural use case.
We have a form with several controls and OK button.
When an user presses OK button we want to check if all values are valid, and if it is so, post these values to the database.

If I understand your words correctly, it is impossible now. But it means that this validation is useless.
A method which would run a validation process and return the result is heavily needed.

[Jorge Sousa]

Hi

You just have to make our app call validate before the ok button, eg, edit change

It's not impossible, and doesn't make the validation useless, like you say.

Ok, we can always improve and do that internally every time a control with change , when validateoptions is active, i think is a better solution for this case.

We don't go running and preview the million thing we could do...

This should be added in very short time,

[asp]

Hi!
I think that doing validation when control value is changed won't help. For example, if we have an empty edit with required validation rule, the user may simply press OK without touching the edit, and the edit will not be validated in this case.

I pay so many attention to the validation because it is one of the most important aspects of the GUI, more important than other bells and whistles.
Best regards.

[Jorge Sousa]

Hello

The attached file contains a few changes to your demo,

that transforms the dialog button's OnClick.OnEvent into OnClick.Script, adding the javascript to call Validate to each validated control

we can make an internal method to be more natural.

Please tell me your thoughts

[asp]

Hi!
Thank you. I'm on vacations now, so I can't test the project for the moment. I'll write you after the holidays. May be you will have the internal method by that time